Revert "Docker: Include Root CA cert needed for APNs (#141)" #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d477292. Since March 29 2021 APNs is no longer using GeoTrust, so this can be removed. See https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_notification_server
Closed
3 tasks
anoadragon453
requested changes
Apr 6, 2021
There was a problem hiding this comment.
From the link:
Communication between your provider server and APNs must take place over a secure connection. Creating that connection requires installing the GeoTrust Global CA root certificate (until March 29, 2021) and the AAA Certificate Services root certificate (starting March 29, 2021) on each of your provider servers.
That date was indeed now passed, and buster's ca-certificates package looks to contain Comodo_AAA_Services_root.crt.
This all lines up with the information in #173, so I think we're good here. Thanks for taking the time to put together this PR!
Last thing I need from you is to sign off on your changes 🙂
|
Sure @anoadragon453, should have added that in the initial PR comment: Signed-off-by: Christoph Settgast [email protected] |
awesome-michael
added a commit
to Awesome-Technologies/sygnal
that referenced
this pull request
May 6, 2021
Sygnal 0.9.3 (2021-04-22) ========================= Features -------- - Prevent the push key from being rejected for temporary errors and oversized payloads, add TTL logging, and support `events_only` push data flag. ([\matrix-org#212](matrix-org#212)) - WebPush: add support for Urgency and Topic header ([\matrix-org#213](matrix-org#213)) Bugfixes -------- - Fix a long-standing bug where invalid JSON would be accepted over the HTTP interfaces. ([\matrix-org#216](matrix-org#216)) - Limit the size of requests received from HTTP clients. ([\matrix-org#220](matrix-org#220)) Updates to the Docker image --------------------------- - Remove manually added GeoTrust Root CA certificate from docker image as Apple is no longer using it. ([\matrix-org#208](matrix-org#208)) Improved Documentation ---------------------- - Make `CONTIBUTING.md` more explicit about how to get tests passing. ([\matrix-org#188](matrix-org#188)) - Update `CONTRIBUTING.md` to specify how to run code style and type checks with Tox, and add formatting to code block samples. ([\matrix-org#193](matrix-org#193)) - Document how to work around pip installation timeout errors. Contributed by Omar Mohamed. ([\matrix-org#215](matrix-org#215)) Internal Changes ---------------- - Update Tox to run in the installed version of Python (instead of specifying Python 3.7) and to consider specific paths and folders while running checks, instead of the whole repository (potentially including unwanted files and folders, e.g. the virtual environment). ([\matrix-org#193](matrix-org#193)) - Make development dependencies available as extras. Contributed by Hillery Shay. ([\matrix-org#194](matrix-org#194)) - Update `setup.py` to specify that a minimum version of Python greater or equal to 3.7 is required. Contributed by Tawanda Moyo. ([\matrix-org#207](matrix-org#207)) - Port CI checks to Github Actions. ([\matrix-org#210](matrix-org#210), [\matrix-org#219](matrix-org#219)) - Upgrade development dependencies. Contributed by Omar Mohamed ([\matrix-org#214](matrix-org#214)) - Set up `coverage.py` to run in tox environment, and add html reports ([\matrix-org#217](matrix-org#217)) Change-Id: I14ae821ff2a1562e91fd87ce25f73baaa0b9430b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d477292.
Since March 29 2021 APNs is no longer using GeoTrust, so this can be removed.
See https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_notification_server